The per-provider disconnect button inside SettingsAccountSheet fired
immediately with no confirmation, unlike the bulk "disconnect all"
row which already shows an AlertDialog. Add the same confirmation
step per provider, reusing the existing settings.disconnect_confirm
string.
Also includes prior in-progress work in this file (sync preferences
section, onAccountChanged wiring, Trakt continue-watching-window and
comments toggle) that was already uncommitted.
Kotlin/Native generates distinct Swift types for a class depending on
whether it's imported directly from its owning module or transitively
re-exported through another framework, so files consuming these DTOs
via FluxaShared's re-export of core no longer matched the FluxaCore
type Loader/ResourceLoader now return directly. Route Bootstrap and
HomeEffectHandler through FluxaCore consistently, and add an explicit
FluxaCore->FluxaShared stream conversion where DetailStartup crosses
back into FluxaApple.shared's Shared-typed API.
Xcode's embedAndSignAppleFrameworkForXcode task for :shared: is
intermittently disabled by the Kotlin Gradle Plugin's own IDE/index-build
detection (onlyIf 'Task is enabled' is false), silently skipping the
framework embed and leaving these types unavailable to Swift. core's
framework already embeds reliably for iOS (matching tvOS), so these plain
DTOs move there instead; the Compose-dependent DataSource wrappers stay in
shared, which already re-exports core.
AndroidDiscoverDataSource duplicated catalog+genre resolution logic
in Kotlin instead of calling discoverSelectionPlan, the same shared
Rust function fluxa-desktop already relies on for this. Route Android
through it too: one implementation for both platforms, and it's more
robust than the Kotlin version since it treats whichever extra a
catalog lists first as the filterable dimension generically, not just
one literally named "genre".
Add DiscoverCatalogOption.extras (carrying each raw catalog extra:
name/options/default/isRequired) and CatalogExtra.default, both
needed for the plan call and previously missing from the addon
manifest models entirely -- the actual bug hunted down across this
and the two preceding core commits was that "default" was dropped at
manifest-parse time in Rust, so no amount of Kotlin plumbing could
have surfaced it.
Catalogs with requiresGenre now pre-select defaultGenre (falling back
to the first available option) instead of leaving the dropdown
looking unselected while discover() silently ran without a genre --
results were already coming back filtered by the addon's own
server-side fallback, but the UI gave no indication why.
The genre dropdown never appeared because loadDiscoverCatalogFilters
-- the only call that fetches real per-catalog genre data -- was
unreachable: the fast local catalog-options path resolved a
catalogKey on almost every call and returned early before ever
reaching it.
Fetch genres in the background right after applying the selected
catalog and kicking off results (matching the existing behavior for
that part exactly, so catalog selection stays instant), instead of
gating catalog selection behind the fetch. Guards on catalogKey
rather than full filter-object equality, since genre/type selections
made while the fetch is in flight shouldn't invalidate it.
EpisodeSelected called dataSource.selectEpisode(episodeId), which
kicks off DetailViewModel.fetchStreamsForSelection, and then also
emitted a SelectSources navigation event that FluxaAppHost handles by
calling detailStore.loadSources(episodeId) -- which starts the exact
same fetch again. fetchStreamsForSelection cancels its previous job
on every call, so the second (navigation-triggered) fetch always
killed the first one before its addon requests could resolve, and the
episode's stream list came back empty even though the addons
genuinely had results (confirmed via logcat: StreamDiscovery reports
600 remote streams found, then the very next fetch attempt logs "NO
STREAMS found" for the same episode).
loadSources already does everything selectEpisode did (marks the
episode selected, then fetches), so the direct selectEpisode call is
redundant -- drop it and let the single navigation-driven fetch run
uncontested.
MainActivity kept its own currentDestination alongside FluxaAppHost's
internal appState.uiState.destination, with only a one-way sync
(external -> internal). Any purely-internal navigation (bottom nav
taps, "switch profiles" from Settings) moved appState's destination
without MainActivity's copy ever finding out. If a later external
navigation call (e.g. profile selection completing) happened to name
a destination MainActivity's stale copy already equaled, it was
treated as a no-op and silently dropped -- reproducible by going
Settings -> Switch profiles -> tapping a profile, which then did
nothing.
Add a callback that mirrors appState's destination back out to
MainActivity whenever it changes internally, and guard the existing
external->internal effect so it only re-applies on a genuine change
(avoiding a reset loop that would otherwise wipe editingProfile/
selectedDetail/etc. on every round trip).
Also account for showProfilePickerSettings in the screen transition
key, which was missing and left the profile picker settings screen
keyed identically to whatever destination was active underneath it.
Forcing the sheet content to a fixed 85% height fraction while also
making it vertically scrollable fought with ModalBottomSheet's own
height/anchor calculations, causing a layout oscillation once the
user scrolled to the end. ModalBottomSheet already bounds its content
to the available window height, so a plain scrollable column is
enough.
Avatar pack image URLs pulled from pack.json can contain literal
spaces (e.g. category folders like "Attack On Titan"). Coil's OkHttp
fetcher and iOS's NSURL.URLWithString both reject unencoded spaces
and fail silently with no placeholder, leaving the thumbnail blank
even though the URL works fine in a browser. Move the sanitizer into
commonMain so both platform image loaders share it.
- Choose Image sheet had no scroll and no height cap, so once avatar
pack content filled the screen there was no way to reach the rest.
Cap it at 85% height and make it scrollable.
- The bottom nav bar avatar, profile edit avatar, and profile grid
avatar each used a different Coil cache key for the same image, so
the bottom bar always cold-loaded from network on every launch
instead of reusing what was already cached. Unify on one key.
- "Manage Profiles" on the who's-watching screen used a fixed bottom
padding that ignored the 3-button navigation bar and sat underneath
it on devices without gesture nav. Add safeDrawing bottom inset
padding.
Restructure into SettingsGroupCard sections (name, PIN/biometric,
danger zone) instead of one flat column, move avatar picking into a
bottom sheet so the main form stays short, and show a dimmed default
avatar placeholder for pack thumbnails that fail to load instead of a
blank circle.
Avatar image URLs pulled from pack.json can contain literal spaces
(e.g. category folders like "Attack On Titan"). Coil's OkHttp fetcher
rejects unencoded spaces and fails silently with no placeholder, so
the thumbnail just stayed blank even though the URL works fine in a
browser. Percent-encode spaces before handing the URL to Coil.
Also label each avatar in the pack picker grid with its name instead
of showing bare, unlabeled images.
Avatar packs were a one-time snapshot from when they were added, so
new images the repo owner pushed later never showed up. Add a
per-pack refresh button in Profile Picker Settings, and re-run
discovery for every saved pack's repository once when the app starts.
Let users customize the "who's watching" screen: add GitHub-hosted
avatar packs to pick profile pictures from, and set a background
image behind the profile grid. The Rust side (GitHub URL/tree/manifest
parsing and validation) already existed in fluxa_core but was never
wired to Kotlin; this adds the FFI wrappers, an OkHttp-driven GitHub
crawl, a small global picker-settings store, and the new/updated
Compose screens. Android only for now — iOS/desktop keep compiling via
default no-op ProfilePersistence methods.
The action, i18n strings, and app-level routing to ProfileList already
existed, but no row in the Settings hub ever called onSwitchProfiles,
so there was no way to reach it from the UI.
Raise SettingsGroupCard contrast with a subtle border, add hairline
row dividers within cards, tighten section header spacing, and
separate the profile row and destructive disconnect action into
their own cards instead of sharing space with unrelated rows.
StreamDiscoveryUseCase now bails out early on a null execution plan
instead of relying on per-field null-safe calls. HomeParentsGuideCoordinator
now imports ImdbApiService from its current package.
Notification title now shows the actual episode/show title with the
release kind as subtext, and season/episode text is generated per case
(episode with title, episode without, season-only) instead of one
generic template. Calendar artwork now prefers the episode-specific
poster before falling back to show-level artwork.
Reworks the player's settings sidebar and input controls, adjusts the
sidebar shell layout, and wires the updated sidebars into the playback
surface and screen content.
Surfaces which item is currently being imported (index/total/title)
under each import step on both mobile and TV auth screens, with a
checkmark for completed steps.
- AddonRepository: cache meta detail lookups with in-flight de-dup, and
race addons instead of fanning out to all of them unconditionally,
cutting redundant requests to slow/duplicate addon instances.
- HomeCatalogFeedCoordinator: publish each background catalog row as it
arrives instead of waiting for a whole batch, and support cancelling
in-flight remaining-catalog loads.
- HomeBillboardRuntime: add a pause for rotation/prefetch/trailer work.
- HomeViewModel: pause Home's background billboard/catalog work when
Discover becomes active so it stops competing for the same addons.
- AndroidDiscoverDataSource: skip redundant addon-list recomputation on
catalog-only filter changes, and move card mapping off the main thread.
- FluxaHeadlessEffectRunner/FluxaHeadlessAppRuntime: narrow the runtime
mutex to only guard Rust engine calls, not the network effects they
trigger, so one screen's dispatch can no longer block another's for
the duration of a slow effect chain.
- NetworkModule: raise the shared OkHttp dispatcher's per-host/total
request ceilings.
Add a topNavigationBar appearance toggle that, on TV and non-compact tablet
widths, moves the navigation destinations into a horizontal bar across the top
instead of the TV sidebar, tablet rail, or bottom bar. Thread the flag through
the settings contract, the Android and Apple settings data sources, the user
profile, and both language files, and render the shared FluxaTopNavBar with
focus restoration on TV.
The TV host forces the Expanded width class, which would otherwise flip the
detail screen into the two-pane tablet layout. Gate the two-pane path on a
non-TV device type so TV keeps its single-column detail.
Introduce an expect/actual TvHeroRow rendered as the first row of the TV home.
The Android actual uses the androidx.tv Carousel with a backdrop, scrim, and
title; iOS gets a no-op since it never renders the TV screens. Wire the shared
androidx.tv dependencies into the shared module's Android source set.
On the Expanded width class, render the detail screen as a fixed hero/metadata
column beside a scrolling episodes/related pane, and the library folder view
beside the library list. Narrower widths keep the single-column layouts. The
detail body and episodes/related items are factored into shared helpers so both
layouts render identical content.
On non-TV hosts at the Expanded width class, replace the bottom navigation bar
with a left navigation rail and inset screen content by its width, mirroring the
TV sidebar layout.
Introduce a runtime WindowWidthClass (Compact/Medium/Expanded) provided at
the app root and use it to drive responsive grid columns on Discover and
Library. Add initial focus, focusRestorer, and focusGroup to the TV home and
sidebar, apply focusRestorer to the shared Discover/Library grids, and
strengthen the focused card highlight.
