Vidsrc DNS error not handled #722

New issue

Closed

opened 2026-02-18 04:38:37 +00:00 by ewwink · 7 comments

ewwink commented

2026-02-18 04:38:37 +00:00

(Migrated from github.com)

Describe the bug
line below does not handle DNS error or domain unreachable (error.code == "EAI_AGAIN"), it throw an error without retrying another domains

fb354b4746/src/extractor/VidSrc.ts (L46)

**Describe the bug** line below does not handle DNS error or domain unreachable `(error.code == "EAI_AGAIN")`, it throw an error without retrying another domains https://github.com/webstreamr/webstreamr/blob/fb354b47461f58a25c245dcac65ca2de26302207/src/extractor/VidSrc.ts#L46 <img width="727" height="483" alt="Image" src="https://github.com/user-attachments/assets/060e0ef7-74b5-4a2e-a09b-8f0092f06be6" />

webstreamr commented

2026-02-18 06:53:03 +00:00

(Migrated from github.com)

Are you self-hosting? What url are you actually opening in the browser there? Not sure if the code is really related to that 🤔

webstreamr commented

2026-02-18 09:22:14 +00:00

(Migrated from github.com)

looks like you have dns issues in your browser/client and not inside webstreamr. I can't handle that, sorry. your ISP might be blocking vidsrc and I suggest that you use another dns

ewwink commented

2026-02-18 10:44:29 +00:00

(Migrated from github.com)

Self-hosted, Image taken from a browser, possibly unrelated, but the error is the same. When webstreamer opens vidsrc-me.su, it fails because the website is down, but I can open other domains such as vidsrcme.ru, vidsrcme.su, vidsrc-embed.ru.

Self-hosted, Image taken from a browser, possibly unrelated, but the error is the same. When webstreamer opens `vidsrc-me.su`, it fails because the website is down, but I can open other domains such as `vidsrcme.ru`, `vidsrcme.su`, `vidsrc-embed.ru`.

webstreamr commented

2026-02-18 14:03:05 +00:00

(Migrated from github.com)

hmm ok, I see. this is bad, because according to https://vidsrc.domains/ that domain should be live. I think webstreamr randomly selects one of the domains, so maybe for now you can just retry such cases? if it keeps being down I'll have to remove it eventually

ewwink commented

2026-02-19 13:32:59 +00:00

(Migrated from github.com)

yes webstreamr randomly selects one of the domains but if dns error it will fail without retry that why I use error.code == "EAI_AGAIN"

if (domains.length && (error instanceof TooManyRequestsError ||  error instanceof BlockedError ||
        error.code == "EAI_AGAIN") // DNS error
    {
        return this.extractUsingRandomDomain(ctx, url, meta, domains);
    }

yes webstreamr randomly selects one of the domains but if dns error it will fail without retry that why I use `error.code == "EAI_AGAIN"` ```javascript if (domains.length && (error instanceof TooManyRequestsError || error instanceof BlockedError || error.code == "EAI_AGAIN") // DNS error { return this.extractUsingRandomDomain(ctx, url, meta, domains); } ```

webstreamr commented

2026-02-20 07:22:36 +00:00

(Migrated from github.com)

Feel free to open a PR if you have time. We could also retry all network related errors there imo

👍 1

webstreamr commented

2026-03-23 16:57:48 +00:00

(Migrated from github.com)

closing due to lack of input. feel free to report back or open a PR as mentioned. not sure if there still issues even