Creepso/webstreamr-github
1
0
Fork 0
Code Issues 27 Pull requests 7 Projects Releases 240 Packages Wiki Activity Actions

Add all domains to streamtape extractoe #489

Merged
GLlgGL merged 33 commits from GLlgGL-patch-4 into main 2025-11-28 15:56:30 +00:00
Conversation 8 Commits 33 Files changed 1 +24 -1
GLlgGL commented 2025-11-06 19:39:14 +00:00 (Migrated from github.com)
Copy link

Hi

Added all domain for streamtape and now is working ok.

Hi Added all domain for streamtape and now is working ok.
webstreamr commented 2025-11-06 22:51:39 +00:00 (Migrated from github.com)
Copy link

I can only consider merging / finishing this if you remove the unrelated changes / addition and follow how it's done elsewhere. Hint: other extractors do it a similar way (regex check of host + list of domains) without needing a public domains property or ai like comments with emojis.

Obvious ai generated slob I can't merge, sorry. Even if it works. I need to keep things maintainable.

I can only consider merging / finishing this if you remove the unrelated changes / addition and follow how it's done elsewhere. Hint: other extractors do it a similar way (regex check of host + list of domains) without needing a public domains property or ai like comments with emojis. Obvious ai generated slob I can't merge, sorry. Even if it works. I need to keep things maintainable.
GLlgGL commented 2025-11-07 06:40:05 +00:00 (Migrated from github.com)
Copy link

I just need to update the promots for the AI to generate responses without changing your code logic.

Don't forgot I know how programming works but I'm not familiar with Typescript...

I wish I had your coding skills but I don't.

I updated the code, now I think you might like lol

I just need to update the promots for the AI to generate responses without changing your code logic. Don't forgot I know how programming works but I'm not familiar with Typescript... I wish I had your coding skills but I don't. I updated the code, now I think you might like lol
webstreamr commented 2025-11-07 07:31:40 +00:00 (Migrated from github.com)
Copy link

Closer I guess, thx. I'd prefer to have domains and general pattern somewhat split as VOE does it. See 57bc4640e5/src/extractor/Voe.ts (L20)

The full domains should not be in the regex please

Closer I guess, thx. I'd prefer to have domains and general pattern somewhat split as VOE does it. See https://github.com/webstreamr/webstreamr/blob/57bc4640e5931ad38d1200027a1f2f68891f18bb/src/extractor/Voe.ts#L20 The full domains should not be in the regex please
GLlgGL commented 2025-11-07 09:00:33 +00:00 (Migrated from github.com)
Copy link

Ok now I think is ok.

Ok now I think is ok.
webstreamr (Migrated from github.com) requested changes 2025-11-07 10:56:48 +00:00
webstreamr (Migrated from github.com) left a comment
Copy link

I think the turbovidplay is still there and needs to be removed please.

I think the turbovidplay is still there and needs to be removed please.
src/extractor/Streamtape.ts
@ -13,7 +13,30 @@ export class Streamtape extends Extractor {
public readonly label = 'Streamtape (via MediaFlow Proxy)';
webstreamr (Migrated from github.com) commented 2025-11-07 10:54:48 +00:00
Copy link

Covered by regex

```suggestion ``` Covered by regex
webstreamr (Migrated from github.com) commented 2025-11-07 10:55:02 +00:00
Copy link

Covered by regex

```suggestion ``` Covered by regex
webstreamr (Migrated from github.com) commented 2025-11-07 10:55:26 +00:00
Copy link

Covered by regex

```suggestion ``` Covered by regex
webstreamr (Migrated from github.com) commented 2025-11-07 10:55:40 +00:00
Copy link

Covered by regex

```suggestion ``` Covered by regex
webstreamr (Migrated from github.com) commented 2025-11-07 10:55:54 +00:00
Copy link

Covered by regex

```suggestion ``` Covered by regex
webstreamr (Migrated from github.com) commented 2025-11-07 10:56:07 +00:00
Copy link

Covered by regex

```suggestion ``` Covered by regex
GLlgGL commented 2025-11-07 11:01:25 +00:00 (Migrated from github.com)
Copy link

Turbovid is on another branch I think...

All the pull requests are from different branches...

Turbovid is on another branch I think... All the pull requests are from different branches...
webstreamr commented 2025-11-07 14:06:13 +00:00 (Migrated from github.com)
Copy link

OK, finally got the workflow actions for PRs fixed. They'll run for your changes too now. As you can see, the tests are red, please fix that. And a big part is because that turbovid file is still here. See also commits. But they don't matter. Just get rid of it here please.

OK, finally got the workflow actions for PRs fixed. They'll run for your changes too now. As you can see, the tests are red, please fix that. And a big part is because that turbovid file is still here. See also commits. But they don't matter. Just get rid of it here please.
GLlgGL commented 2025-11-07 14:35:03 +00:00 (Migrated from github.com)
Copy link

I removed turbovid completly

Should run fine now...

I removed turbovid completly Should run fine now...
webstreamr commented 2025-11-07 22:47:54 +00:00 (Migrated from github.com)
Copy link

Tests are failing. But you should get notifications for this or be able to check yourself.

Tests are failing. But you should get notifications for this or be able to check yourself.
GLlgGL (Migrated from github.com) reviewed 2025-11-08 08:20:34 +00:00
GLlgGL (Migrated from github.com) left a comment
Copy link

Both tests passed now lol.

Both tests passed now lol.
webstreamr (Migrated from github.com) reviewed 2025-11-08 13:47:53 +00:00
src/extractor/Streamtape.ts
webstreamr (Migrated from github.com) commented 2025-11-08 13:47:52 +00:00
Copy link
  };

Avoid unnecessary changes and/or check better what the ai tooling does if you want to get your changes merged

```suggestion }; ``` Avoid unnecessary changes and/or check better what the ai tooling does if you want to get your changes merged
webstreamr (Migrated from github.com) reviewed 2025-11-08 13:48:44 +00:00
src/extractor/Streamtape.ts
webstreamr (Migrated from github.com) commented 2025-11-08 13:48:44 +00:00
Copy link

This is not an issue per se, but it annoys me tbh and it is somewhat bad contribution manners

This is not an issue per se, but it annoys me tbh and it is somewhat bad contribution manners
webstreamr (Migrated from github.com) reviewed 2025-11-28 15:54:21 +00:00
src/extractor/Streamtape.ts
@ -13,7 +13,30 @@ export class Streamtape extends Extractor {
public readonly label = 'Streamtape (via MediaFlow Proxy)';
webstreamr (Migrated from github.com) commented 2025-11-28 15:54:21 +00:00
Copy link
 protected async extractInternal(ctx: Context, url: URL, meta: Meta): Promise<UrlResult[]> {

let's keep this as it was

```suggestion protected async extractInternal(ctx: Context, url: URL, meta: Meta): Promise<UrlResult[]> { ``` let's keep this as it was
webstreamr (Migrated from github.com) reviewed 2025-11-28 15:54:49 +00:00
src/extractor/Streamtape.ts
@ -13,7 +13,30 @@ export class Streamtape extends Extractor {
public readonly label = 'Streamtape (via MediaFlow Proxy)';
webstreamr (Migrated from github.com) commented 2025-11-28 15:54:49 +00:00
Copy link
  protected async extractInternal(ctx: Context, url: URL, meta: Meta): Promise<UrlResult[]> {

missing space from my last suggestion 🙈

```suggestion protected async extractInternal(ctx: Context, url: URL, meta: Meta): Promise<UrlResult[]> { ``` missing space from my last suggestion 🙈
webstreamr (Migrated from github.com) approved these changes 2025-11-28 15:56:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
webstreamr
Labels
Clear labels   
MediaFlow Proxy

   
autorelease: pending

   
autorelease: tagged

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
🇩🇪 German

   
🇫🇷 French

   
🇮🇳 Indian

   
🇸🇦 Arabic

   
🌐 Multi
No labels
MediaFlow Proxy
autorelease: pending
autorelease: tagged
bug
documentation
duplicate
enhancement
help wanted
invalid
question
wontfix
🇩🇪 German
🇫🇷 French
🇮🇳 Indian
🇸🇦 Arabic
🌐 Multi
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/webstreamr-github#489
No description provided.
Delete branch "GLlgGL-patch-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?