Include subtitles #156
Labels
No labels
MediaFlow Proxy
autorelease: pending
autorelease: tagged
bug
documentation
duplicate
enhancement
help wanted
invalid
question
wontfix
🇩🇪 German
🇫🇷 French
🇮🇳 Indian
🇸🇦 Arabic
🌐 Multi
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Creepso/webstreamr-github#156
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Many sources also link subtitles. Scraping and returning them as well would be quite useful.
https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/responses/stream.md
Yes we need this :P
@GLlgGL which are the embed hosters you miss subtitles the most? some hls streams should have them included already, e.g. vixsrc. others, e.g. supervideo not I think. I can look into adding them one by one, but want to stat with the important ones
voe and vidmoly
https://github.com/webstreamr/webstreamr/issues/652
but we need for all which include subtitles
you added subtitle examples to the other ticket, yeah, but if you stumble over examples again please add an embed example if you can. I just tried briefly yesterday we 2 voe ones and they didn't have subtitles. and obviously I'm too lazy to search forever :D
Sure.
Both are sq(Albanian language subtitles)
Embed Voe
https://lauradaydo.com/e/ulboixw1h5amSubtitle Voe
https://lauradaydo.com/vtt/ulboixw1h5am_sq.srtEmbed Vidmoly
https://vidmoly.net/embed-a3g0r5g2awqn.htmlSubs Vidmoly
https://srt.vidmoly.me/srt/02170/a3g0r5g2awqn_English.vttFor voe the srt file can be found on the final part after decoding where the final hls link lives...
So two things needed
I was able to make it work and return the subtitles to stremio so just dont lose your time with it...
I will do a PR for VOE so you can look and if interested you can do your edits and merge
I will do atry with vidmoly as I already have it intagrated as extractor on my copy of your addon but the vidmoly is a bit tricky as it doesnt allow multiple requests(it shows a captcha window if detectes that)...
I was able to indentify also the subtitles link on the vidmoly
Do you know if stremio plays .vtt files? Because on voe which had .srt is working but on vidmoly with .vtt something is wrong and the subtitles doesnt load
Nevermind I was able to fix it.
Do you need my help with any other extractor which you need subtitles? And of course you have an embed link for it.
If not than we can close this for now.
let's keep it open, I want to go through extractors one by one and add subtitle export where it's possible/needed.
I tried kinoger 2 days ago and also wasn't able to make vtt work. but I didn't look much closer yet. I think they should work.
Post embed here which has subtitles included
I made it work with vidmoly...They should work but we need to check if the link needs referer(headers or something).
Incase of vidmoly
I changed from this(not working) srt.vidmoly.me to vidmoly.net and worked.
Can you do a test with my code for voe subtitles
For me this works
https://lauradaydo.com/e/ezihzkn6hioxThis doesnt
https://lauradaydo.com/e/wjebgnhvl1faUsing same code to debug shows the subtitles for both.
I am investigating why doesnt load for the second one...They doesnt load even if I do fallback by building the subtitles link manually with ID+language like
wjebgnhvl1fa_sq.srtI think is a cache thing or something because using new embeds which i didnt opened before they all work and show subtitles for voe and vidmoly .srt and .vtt...So code is correct
On the old embeds they dont show both for voe and vidomoly...is not that it doesnt work for voe but works for vidmoly...This means it might be a cache thingy...Anyway do your tests and let me know.
ps...I dont think is a cache problem...
The strange thing is that when the subtitles dont work, dont work for both of them, when they work, work for both...
This is very strange...
Maybe a formating issue inside subtitles which makes stremio dont load them?
Definitly a formating issue as observed also by Gemeni AI. Also from my observation because when they dont work they dont work on both vidmoly and voe together.
So the code I PR is working good. We just need to find out what is the formating issue .
In loading the subtitles in the vlc works though so it might be only a stremio issue
jfy if you do local development I suggest to configure
CACHE_DIR=/dev/nullandNODE_ENV=devto rule out and avoid cache issuesYeah I should do that of course...Anyway its not a cache problem. I am also testing on a old version where you had that disable cache button.
The problem is the subtitle format inside.
And stremio might be strict about it and doesnt load them.
So this is not a thing we can fix. Maybe I will open an issue on stremio git about it and their devs might fix why one of them doesnt load.
Anyway checking them inside doesn't seem to have any difference for me...
This is very strange...
I found what is the problem.
So its a format problem not a code or stremio problem(vlc and some other players are less restrictive and plays them and maybe stremio doesnt)
Opened an issue on stremio for them to check
https://github.com/Stremio/stremio-bugs/issues/2161