build(docker): clean-up needed env vars, use sane defaults

.github/workflows/build.yml

@@ -11,8 +11,5 @@ jobs:
         name: Build and push
         uses: docker/build-push-action@v6
         with:
-          build-args: |
-            MANIFEST_ID="community.webstreamr"
-            MANIFEST_NAME="WebStreamr"
           push: false
           tags: webstreamr/webstreamr:latest

Dockerfile

@@ -16,17 +16,6 @@ WORKDIR /app
 COPY --from=builder /app/dist ./dist
 COPY --from=builder /app/node_modules ./node_modules
 
-ARG PORT
-
-ARG MANIFEST_ID
-RUN test -n "$MANIFEST_ID" || (echo "MANIFEST_ID is not set" && exit 1)
-
-ARG MANIFEST_NAME
-RUN test -n "$MANIFEST_NAME" || (echo "MANIFEST_NAME is not set" && exit 1)
-
-ENV MANIFEST_ID=$MANIFEST_ID
-ENV MANIFEST_NAME=$MANIFEST_NAME
 ENV NODE_ENV=production
-ENV PORT=$PORT
 
 CMD ["node", "dist/server.js"]

jest.config.ts

@@ -20,7 +20,6 @@ const config: Config = {
     },
   },
   restoreMocks: true,
-  setupFilesAfterEnv: ['./jest.setup.ts'],
   testEnvironment: 'node',
   transform: {
     '^.+.tsx?$': ['ts-jest', {}],

jest.setup.ts

@@ -1,2 +0,0 @@
-process.env['MANIFEST_ID'] = 'community.webstreamr';
-process.env['MANIFEST_NAME'] = 'WebStreamr';

src/addon.test.ts

@@ -1,10 +1,11 @@
 import addon from './addon';
 
 describe('addon', () => {
-  test('manifest can be retrieved', () => {
+  test('manifest can be retrieved with defaults', () => {
     expect(addon.manifest).toStrictEqual(
       expect.objectContaining({
-        id: 'community.webstreamr',
+        id: 'webstreamr',
+        name: 'WebStreamr',
       }),
     );
   });

src/addon.ts

@@ -8,9 +8,9 @@ const handlers: Handler[] = [
 ];
 
 const manifest: Manifest = {
-  id: process.env['MANIFEST_ID'] || '',
+  id: process.env['MANIFEST_ID'] || 'webstreamr',
   version: '0.2.0', // x-release-please-version
-  name: process.env['MANIFEST_NAME'] || '',
+  name: process.env['MANIFEST_NAME'] || 'WebStreamr',
   description: `Provides HTTP URLs from streaming websites.`,
   resources: [
     'stream',