From ae4bfda5545ce6adb95640c198839e7f0f693467 Mon Sep 17 00:00:00 2001 From: NikolaBorislavovHristov Date: Sat, 5 Oct 2019 12:00:06 +0300 Subject: [PATCH] unsubscrive from onchange listener on unmount --- src/common/ColorPicker/ColorPicker.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/common/ColorPicker/ColorPicker.js b/src/common/ColorPicker/ColorPicker.js index aba4e053f..223cefbb1 100644 --- a/src/common/ColorPicker/ColorPicker.js +++ b/src/common/ColorPicker/ColorPicker.js @@ -21,12 +21,14 @@ const ColorPicker = ({ className, value, onChange }) => { }); }, []); React.useEffect(() => { - pickerRef.current.off('change'); pickerRef.current.on('change', (picker, color) => { if (typeof onChange === 'function') { onChange(AColorPicker.parseColor(color, COLOR_FORMAT)); } }); + return () => { + pickerRef.current.off('change'); + }; }, [onChange]); React.useEffect(() => { if (AColorPicker.parseColor(pickerRef.current.color, COLOR_FORMAT) !== value) {