From 2c7d9251d5a0b85874255408b12456b0c9deabe4 Mon Sep 17 00:00:00 2001 From: Alexandru Branza Date: Mon, 29 May 2023 19:23:42 +0300 Subject: [PATCH] Don't Use `a href` Anymore When Handling External Player Open With Local Server --- src/routes/MetaDetails/StreamsList/Stream/Stream.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/routes/MetaDetails/StreamsList/Stream/Stream.js b/src/routes/MetaDetails/StreamsList/Stream/Stream.js index 627352f8d..f0dda4eff 100644 --- a/src/routes/MetaDetails/StreamsList/Stream/Stream.js +++ b/src/routes/MetaDetails/StreamsList/Stream/Stream.js @@ -19,7 +19,7 @@ const Stream = ({ className, addonName, name, description, thumbnail, progress, profile.settings.playerType === 'external' ? platform.isMobile() || !haveStreamingServer ? (deepLinks.externalPlayer.vlc || {})[platform.name] || deepLinks.externalPlayer.href - : 'javascript:void(0);' + : null : typeof deepLinks.player === 'string' ? deepLinks.player @@ -29,7 +29,7 @@ const Stream = ({ className, addonName, name, description, thumbnail, progress, null; }, [deepLinks]); const onClick = React.useCallback((e) => { - if (e.target.closest('a').getAttribute('href') === 'javascript:void(0);') { + if (href === null) { // link does not lead to the player, it is expected to // open with local video player through the streaming server core.transport.dispatch({ @@ -44,7 +44,7 @@ const Stream = ({ className, addonName, name, description, thumbnail, progress, }); } props.onClick(e); - }, [deepLinks, props.onClick]); + }, [href, deepLinks, props.onClick]); const forceDownload = React.useMemo(() => { // we only do this in one case to force the download // of a M3U playlist generated in the browser