[BUG] [Funimation/Crunchy] dlsubs "en" option missing causing Invalid Argument errors #181

New issue

Closed

opened 2021-12-07 19:11:15 +00:00 by XxUnkn0wnxX · 9 comments

XxUnkn0wnxX commented 2021-12-07 19:11:15 +00:00 (Migrated from github.com)

Copy link

** Main info: **

Script version: Multi Downloader NX 2.0.7 Commit: 667f02fae2
Service: Funi & Crunchy (Argument Belongs to Crunchy, triggers on any service though due to config file)
Show ID: N/A
Episode ID: N/A
Command used: aniDL --service crunchy --dlsubs en

Console output:

Invalid values:
  Argument: dlsubs, Given: "en", Choices: "all", "none", "es-419", "es", "pt-BR", "fr", "de", "ar", "it", "ru", "tr", "ja", "zh"

** Additional Info: **

What happened to "en" English support for subs?

I started getting this error after some recent updates. this initially triggered because I always had this in my config

<!-- Please fill in the placeholders.--> ** Main info: ** Script version: Multi Downloader NX 2.0.7 Commit: 667f02fae25db3dd10454e3901562bfe8b62289e Service: Funi & Crunchy (Argument Belongs to Crunchy, triggers on any service though due to config file) Show ID: N/A Episode ID: N/A Command used: aniDL --service crunchy --dlsubs en <!-- Make sure you don't leak your token. This should only be a concern when you are using the --debug flag --> Console output: ```text Invalid values: Argument: dlsubs, Given: "en", Choices: "all", "none", "es-419", "es", "pt-BR", "fr", "de", "ar", "it", "ru", "tr", "ja", "zh" ``` ** Additional Info: **   What happened to "en" English support for subs? I started getting this error after some recent updates. this initially triggered because I always had this in my config 

XxUnkn0wnxX commented 2021-12-07 19:34:52 +00:00 (Migrated from github.com)

Copy link

also, no streams are being detected for any shows on Funimation...

aniDL --service funi -s 2831743 -e 9
aniDL --service funi -s 1311428 -e 21

Show ID: 2831743, EP 9 (Deep Insanity: The Lost Child)
Show ID: 1311428, EP 21 (Mushoku Tensei: Jobless Reincarnation)

Says track not selected... & it's not showing any available streams.

Also running npm run tsc
Is giving me that strange error again

❯ npm run tsc

> multi-downloader-nx@2.0.7 tsc
> ts-node tsc.ts

Error: ENOTEMPTY: directory not empty, rmdir 'lib/node_modules'
    at Object.rmdirSync (node:fs:1167:10)
    at _rmdirSync (node:internal/fs/rimraf:260:21)
    at rimrafSync (node:internal/fs/rimraf:193:7)
    at node:internal/fs/rimraf:253:9
    at Array.forEach (<anonymous>)
    at _rmdirSync (node:internal/fs/rimraf:250:7)
    at rimrafSync (node:internal/fs/rimraf:193:7)
    at Object.rmSync (node:fs:1214:10)
    at removeSync (/Users/USER/Apps/Animie/anidl/multi-downloader-nx/node_modules/fs-extra/lib/remove/index.js:15:28)
    at /Users/USER/Apps/Animie/anidl/multi-downloader-nx/tsc.ts:22:13 {
  errno: -66,
  syscall: 'rmdir',
  code: 'ENOTEMPTY',
  path: 'lib/node_modules'
}

also, no streams are being detected for any shows on Funimation... `aniDL --service funi -s 2831743 -e 9` `aniDL --service funi -s 1311428 -e 21` Show ID: 2831743, EP 9 (Deep Insanity: The Lost Child) Show ID: 1311428, EP 21 (Mushoku Tensei: Jobless Reincarnation)   Says track not selected... & it's not showing any available streams. Also running `npm run tsc` Is giving me that strange error again ```text ❯ npm run tsc > multi-downloader-nx@2.0.7 tsc > ts-node tsc.ts Error: ENOTEMPTY: directory not empty, rmdir 'lib/node_modules' at Object.rmdirSync (node:fs:1167:10) at _rmdirSync (node:internal/fs/rimraf:260:21) at rimrafSync (node:internal/fs/rimraf:193:7) at node:internal/fs/rimraf:253:9 at Array.forEach (<anonymous>) at _rmdirSync (node:internal/fs/rimraf:250:7) at rimrafSync (node:internal/fs/rimraf:193:7) at Object.rmSync (node:fs:1214:10) at removeSync (/Users/USER/Apps/Animie/anidl/multi-downloader-nx/node_modules/fs-extra/lib/remove/index.js:15:28) at /Users/USER/Apps/Animie/anidl/multi-downloader-nx/tsc.ts:22:13 { errno: -66, syscall: 'rmdir', code: 'ENOTEMPTY', path: 'lib/node_modules' } ```

izu-co commented 2021-12-07 19:37:46 +00:00 (Migrated from github.com)

Copy link

Alright so...
As you might have noticed, I have merged the command line arguments for subs and dubs for both funi and crunchy into one per category. Track not selected just means that you haven't selected the Japanese audio. Please refer to the help for the new options for subs and dubs.

As to where the en sub went - idfk I will take a look into it tomorrow

Alright so... As you might have noticed, I have merged the command line arguments for subs and dubs for both funi and crunchy into one per category. Track not selected just means that you haven't selected the Japanese audio. Please refer to the help for the new options for subs and dubs. As to where the en sub went - idfk I will take a look into it tomorrow

izu-co commented 2021-12-07 19:53:53 +00:00 (Migrated from github.com)

Copy link

Should be tho...

Should be tho...

XxUnkn0wnxX commented 2021-12-07 19:55:14 +00:00 (Migrated from github.com)

Copy link

ya i saw its in help page...

to DL subs only now such a long command though aniDL --service funi -s 2831743 -e 9 --dubLang jpn --novids --noaudio --dlsubs all "all" still works just cant specify "en" for English only :(

Suggestion:
when you get the time as you update & merge new arguments maybe keep the default cli-defaults.yml labelled like what option applies to what etc...

ya i saw its in help page... to DL subs only now such a long command though `aniDL --service funi -s 2831743 -e 9 --dubLang jpn --novids --noaudio --dlsubs all` "all" still works just cant specify "en" for English only :( Suggestion: when you get the time as you update & merge new arguments maybe keep the default `cli-defaults.yml` labelled like what option applies to what etc... 

izu-co commented 2021-12-07 20:17:25 +00:00 (Migrated from github.com)

Copy link

I plan to auto create the CLI defaults file when the programm is build

I plan to auto create the CLI defaults file when the programm is build

izu-co commented 2021-12-07 21:03:47 +00:00 (Migrated from github.com)

Copy link

For now, the newest commit is fixing the English problem

For now, the newest commit is fixing the English problem

XxUnkn0wnxX commented 2022-01-06 15:55:04 +00:00 (Migrated from github.com)

Copy link

@izu-co as of commit: c89cea218c this is broken again
I have dlSubs: en set in config, i tried to set "none" "jp" etc and within the config, it just doesn't recognise it, it keeps saying the default is all even though its not

also, the flag partsize is also gone, doesn't respect config or have a flag for it..

@izu-co as of commit: c89cea218c3fe00b64429b6ab17d85e57bf745f0 this is broken again I have `dlSubs: en` set in config, i tried to set "none" "jp" etc and within the config, it just doesn't recognise it, it keeps saying the default is all even though its not  also, the flag `partsize` is also gone, doesn't respect config or have a flag for it..

izu-co commented 2022-01-06 16:22:44 +00:00 (Migrated from github.com)

Copy link

Will look into it

Will look into it

izu-co commented 2022-01-06 16:47:03 +00:00 (Migrated from github.com)

Copy link

I just looked into it @XxUnkn0wnxX, and I've changed dlSubs to dlsubs. Since the newest update, all config option are exactly the same as if you would pass it to args. So since it would be --dlsubs it is also now dlsubs: [number] in the config.

As for the missing partsize, this has been added with 05d65d3d54.

I just looked into it @XxUnkn0wnxX, and I've changed `dlSubs` to `dlsubs`. Since the newest update, all config option are `exactly` the same as if you would pass it to args. So since it would be `--dlsubs` it is also now `dlsubs: [number]` in the config. As for the missing partsize, this has been added with 05d65d3d540b6c439184676598f77c817e0bc62f.

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

syncV3

dependabot/npm_and_yarn/types/node-22.5.5

dependabot/npm_and_yarn/gui/react/micromatch-4.0.8

dependabot/npm_and_yarn/micromatch-4.0.8

dependabot/npm_and_yarn/gui/react/webpack-5.94.0

guiv3

dependabot/npm_and_yarn/leven-4.0.0

dependabot/npm_and_yarn/braces-3.0.3

dependabot/npm_and_yarn/gui/react/braces-3.0.3

multi-download

dependabot/npm_and_yarn/babel/traverse-7.24.1

dependabot/npm_and_yarn/open-10.1.0

native-mp4decrypt

sync

v5.1.5

v5.1.4

v5.1.3

v5.1.2

v5.1.1

v5.1.0

v5.0.3

v5.0.2

v5.0.1

v5.0.0

v4.7.1

v4.7.0

v4.6.3

v4.6.2

v4.6.1

v4.6.0

v4.5.2

v4.5.1

4.5.0-rc1

4.4.3

4.4.1

4.4.0

4.3.0

4.2.0

4.1.0

4.0.3

4.0.2

4.0.1

4.0.0

3.4.4

3.4.0

3.3.6

3.3.5

3.3.4

3.3.3

3.3.2

3.3.1

3.3.0

3.2.0

3.1.0

0.0.1

3.0.7

3.0.6

3.0.5

3.0.4

3.0.3

3.0.2

3.0.1

3.0.0

0.0.0

2.0.18

2.0.17

2.0.16

2.0.15

2.0.14

2.0.13

2.0.12

2.0.11

2.0.10

2.0.9

2.0.8

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.1.1

1.1.0

1.0.4

1.0.3

1.0.2

1.0.1

1.0.0

Labels

Clear labels   

Wrong-Place

This is the wrong place to write this

  

bug

Something isn't working

  

cli

Used for CLI problems

  

dependencies

Pull requests that update a dependency file

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

ice

This issue is currently on ice. It may be worked on in the feature, but not in the near future

  

invalid

This doesn't seem right

  

question

Further information is requested

  

request

Used this if you want to request e.g. a feature

  

wontfix

This will not be worked on

No labels

Wrong-Place

bug

cli

dependencies

documentation

duplicate

enhancement

good first issue

help wanted

ice

invalid

question

request

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Creepso/multi-downloader-nx#181

No description provided.