Creepso/fluxa-core
1
0
Fork 0
mirror of https://github.com/FluxaMedia/fluxa-core.git synced 2026-08-19 13:35:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(core): fall back to score when a rating source's value is null

Browse source 
MDBList returns {"value": null, "score": null} for unrated sources
(e.g. myanimelist on non-anime titles) rather than omitting the key.
The previous or_else only triggered when "value" was absent, not when
present-but-null, so a source with null value and a real score never
fell through.
This commit is contained in:
KhooLy 2026-07-29 02:55:12 +03:00
parent cfea89163d
commit d5d144e550
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/mdblist_plan.rs
View file

@ -172,7 +172,10 @@ pub(crate) fn mdblist_media_ratings_from_response_json(response_json: &str) -> O
let mut normalized = serde_json::Map::new();
for entry in ratings {
let source = entry.get("source").and_then(Value::as_str)?;
let value = entry.get("value").or_else(|| entry.get("score"));
let value = entry
.get("value")
.filter(|value| !value.is_null())
.or_else(|| entry.get("score").filter(|score| !score.is_null()));
if let Some(value) = value {
normalized.insert(source.to_string(), value.clone());
}
@ -790,7 +793,9 @@ mod tests {
let response = json!({
"ratings": [
{ "source": "imdb", "value": 9.3 },
{ "source": "tmdb", "score": 88 }
{ "source": "tmdb", "score": 88 },
{ "source": "myanimelist", "value": null, "score": null },
{ "source": "metacriticuser", "value": null, "score": 75 }
]
})
.to_string();
@ -799,6 +804,8 @@ mod tests {
.unwrap();
assert_eq!(normalized["imdb"], 9.3);
assert_eq!(normalized["tmdb"], 88);
assert!(normalized.get("myanimelist").is_none());
assert_eq!(normalized["metacriticuser"], 75);
}
#[test]