mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-08-06 14:10:43 +00:00
Settle the Playwright-grade reliability contract in agent-desktop-core before the Windows/Linux adapters are built, so they inherit it instead of redesigning it. Every command now observes, waits, verifies, and reports honestly instead of firing blindly. Highlights: capability-supertrait split of PlatformAdapter with not_supported() defaults; canonical role/state vocabulary with live `is --property visible`; display enumeration (`list-displays`) and honest `--screen` with scale factor; truthful Automation permission; `native_id` identity spine; window-id-first resolution; serializable `LocatorQuery` with live `find`; default-on auto-wait before every ref action; three-way `hit_test` occlusion gate; `scroll_into_view` in core; core accessible-name precedence; typed `ActionStep` delivery tier; `ProcessState` and `APP_UNRESPONSIVE`; `LaunchOptions`; baseline-diff desktop signals (`wait --event`); typed clipboard (`Text`/`Image`/`FileUrls`); mouse modifier chords and `mouse-wheel`. Hardened through a 35-reviewer pass with independent validation and a green live e2e gate (109/0), plus a head-vs-main performance comparison harness. BREAKING CHANGE: default-on auto-wait changes the timing of every previously-untouched ref-action call (bounded 5000 ms default; `--timeout-ms 0` restores single-shot). `ENVELOPE_VERSION` is now `2.1` (adds the `APP_UNRESPONSIVE` code and process state in error details). FFI ABI major is `3` (append-only struct evolution; `wait --event` is intentionally not exposed over FFI). The legacy string clipboard API is removed in favor of typed content. `key-down`/`key-up` fail closed until daemon-owned held input exists. `close-app` verifies termination and the osascript fallback path is removed. `--text` matching is subtree containment: `find --text X --first` returns the outermost matching container.
25 lines
637 B
Rust
25 lines
637 B
Rust
use super::resolve_end_session_id;
|
|
|
|
#[test]
|
|
fn explicit_session_end_id_precedes_active_scope() {
|
|
assert_eq!(
|
|
resolve_end_session_id(Some("explicit".into()), Some("active")).unwrap(),
|
|
"explicit"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn session_end_falls_back_to_active_scope() {
|
|
assert_eq!(
|
|
resolve_end_session_id(None, Some("active")).unwrap(),
|
|
"active"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn session_end_without_any_scope_is_invalid() {
|
|
let error = resolve_end_session_id(None, None).expect_err("missing scope must fail");
|
|
|
|
assert_eq!(error.code(), "INVALID_ARGS");
|
|
assert!(error.to_string().contains("No session id"));
|
|
}
|