mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-08-04 21:20:48 +00:00
eb9f7c0f06
Addresses the code review's remaining validated findings (test + robustness hardening; no P0 correctness left after the name and window-bridge fixes): - find --window-id: MockAdapter test (two windows, distinct trees) proving the flag scopes the search to the requested window and a swap with app would fail. - WindowScope serde: batch-JSON back-compat + typo-rejection tests for the flattened app/window_id group on find/snapshot/screenshot. - Offscreen bounds: extracted window_bounds_for_children as a pure helper and restored the AXWindow-own-bounds / inherited-fallback unit coverage that was lost when the live query matcher was deleted. - Real-app guards: the #[ignore] snapshot_test.rs guards now print a SKIP reason before each early return, so a no-op run is visible instead of a silent pass. - Hit-test occluder naming now applies promoted_label.or_else(resolve_element_name), matching the strict resolver and ambiguity classifier. - Hover e2e asserts a clean (non-"hovered") baseline after the cursor reset. Verified: e2e 71/0, Finder sidebar cells still re-resolve, clippy + workspace tests green. |
||
|---|---|---|
| .. | ||
| conformance | ||
| e2e | ||
| ffi-python | ||
| fixture-app | ||
| fixtures | ||
| support | ||