mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-08-06 06:00:39 +00:00
640e8e83e4
Triage + validate (the review's line numbers were bogus diff-offset artifacts, so every finding was checked against the real code) then fix the real ones. 4 findings were false-positives (#2 core-internal fn, #5 VisibilityEvidence not in the actionability gate, #15 supertrait forward-design, #20 as_str duplication), 2 were deferred as disproportionate (see below). Verified by an adversarial code-read review + full gate: fmt, clippy -D warnings, 1006 lib + 7 ABI tests, core isolation, 1.6MB, e2e 72/0, FFI header regenerated with matching offset asserts. - scroll gate: maybe_scroll_into_view now reads live state/bounds (fail-open to the snapshot entry on capability-less adapters) so an element that scrolled off-screen after the snapshot is still scrolled into view - auto-wait: is_permanent_error now treats ErrorCode::Internal as permanent so an internal dispatch error fails fast instead of retrying the whole budget - FFI header: document ad_execute_by_ref's 5000ms auto-wait default (and the timeout=0 single-shot escape hatch); correct the stale envelope version 2.0 -> 2.1; add the 22 per-field offsetof static asserts for AdRefEntry - skill docs: document --modifiers on the mouse commands, the receives_events occlusion check + occluder detail, the implicit scroll-into-view preflight, and --timeout-ms — and correct the actionability section to reflect that hover/drag run only the receives_events check (not the full battery) and fail fast with ACTION_FAILED rather than polling to TIMEOUT - adapter: /// note that get_clipboard/set_clipboard were removed pre-1.0 for the typed content methods (C ABI unaffected) - tests: StepMechanism serde roundtrip, ActionRequest legacy-no-timeout_ms deserialization, execute_by_ref unit tests; dedup the byte-identical StaleThenOkAdapter retry-counter into stale_retry_test_support Deferred (disproportionate blast radius, tracked as follow-up issues): process-state PID-reuse start-time corroboration (needs plumbing through the already-large RefEntry + snapshot + platform adapter); a stub_ops! macro + 84-site test-adapter retrofit (large mechanical churn on the deliberate U0 four-trait split). |
||
|---|---|---|
| .. | ||
| core | ||
| ffi | ||
| linux | ||
| macos | ||
| windows | ||