mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-08-05 05:30:21 +00:00
413cf903e7
Sweep crates/ffi/ docstrings per the review ask ("make them
comprehensive, remove the unwanted ones"):
- ad_adapter_create: add missing header — ownership, lifetime, failure
mode.
- ad_last_error_{code,message,suggestion,platform_detail}: each gets a
dedicated 1-2 line doc; the errno-style lifetime block kept above
ad_last_error_code as the anchor for the family.
- ad_drag: explain duration_ms == 0 semantics.
- ad_mouse_event: note click_count only applies to the CLICK kind.
- ad_get_clipboard / ad_set_clipboard / ad_clear_clipboard /
ad_free_string: clarify UTF-8 input, error branch, null-tolerance,
and double-free semantics.
- ad_focus_window: document window-not-found error and id/title
prerequisites.
- ad_window_op: explain which op.kind fields are read.
- ad_launch_app: document return-ownership of AdWindowInfo and the
zero-on-error contract.
- ad_close_app: document force-flag semantics.
- ad_get_tree: describe BFS layout, options, and out-param zeroing.
Remove test-intent //-comments that were already captured in renamed
test names:
- enum_validation::fuzz_arbitrary_bit_patterns_never_panic_across_all_enums
- main_thread::is_main_thread_call_is_always_safe_even_on_workers
- main_thread::debug_assert_panic_on_worker_thread_does_not_escape_catch_unwind
Tighten the two retained //-blocks (error.rs parity assertion, build.rs
cbindgen-false semantics) so each explains a non-obvious invariant a
future reader couldn't infer from code alone.
62 FFI tests pass. Clippy clean.
|
||
|---|---|---|
| .. | ||
| core | ||
| ffi | ||
| linux | ||
| macos | ||
| windows | ||