Lahfir ee2374e565 feat(ffi): build hygiene — pinned cbindgen, drift check, variant parity (Unit 12) ... Closes R14, R19, R20, R23 from PR #22 review. Build pipeline: - crates/ffi/Cargo.toml: pin cbindgen = "= 0.27.0" exactly. No more silent formatting drift from patch-version bumps of cbindgen; any future bump is a deliberate PR that also commits the regenerated header. - crates/ffi/build.rs: replace .expect()/.ok() swallowing with explicit panics on every failure path. Missing CARGO_MANIFEST_DIR or OUT_DIR now emits a cargo:warning rather than crashing rustc. cbindgen errors now panic loudly with the diagnostic; previously an .ok() on fs::copy silently emitted a stale header. CI: - .github/workflows/ci.yml: new "FFI cdylib build" step under the release-ffi profile and a "FFI header drift" step that runs `git diff --exit-code crates/ffi/include/agent_desktop.h` immediately after. Any uncommitted change to the generated header fails the build with a clear message telling the developer to run the local rebuild and commit. Variant parity: - crates/ffi/src/error.rs: compile-time assertion `const _: () = assert!(error_code_variant_count() == ad_result_error_variant_count())` guards against core adding an ErrorCode variant without a matching AdResult entry (which would silently drop information at the FFI boundary). Uses stable const fn + explicit variant arrays, no nightly variant_count feature. 50 lib tests, 1 integration test — all passing. Clippy clean.		2026-04-16 03:58:30 -07:00
..
workflows	feat(ffi): build hygiene — pinned cbindgen, drift check, variant parity (Unit 12)	2026-04-16 03:58:30 -07:00