mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-08-03 04:36:37 +00:00
3f322728b4
Settle the Playwright-grade reliability contract in agent-desktop-core before the Windows/Linux adapters are built, so they inherit it instead of redesigning it. Every command now observes, waits, verifies, and reports honestly instead of firing blindly. Highlights: capability-supertrait split of PlatformAdapter with not_supported() defaults; canonical role/state vocabulary with live `is --property visible`; display enumeration (`list-displays`) and honest `--screen` with scale factor; truthful Automation permission; `native_id` identity spine; window-id-first resolution; serializable `LocatorQuery` with live `find`; default-on auto-wait before every ref action; three-way `hit_test` occlusion gate; `scroll_into_view` in core; core accessible-name precedence; typed `ActionStep` delivery tier; `ProcessState` and `APP_UNRESPONSIVE`; `LaunchOptions`; baseline-diff desktop signals (`wait --event`); typed clipboard (`Text`/`Image`/`FileUrls`); mouse modifier chords and `mouse-wheel`. Hardened through a 35-reviewer pass with independent validation and a green live e2e gate (109/0), plus a head-vs-main performance comparison harness. BREAKING CHANGE: default-on auto-wait changes the timing of every previously-untouched ref-action call (bounded 5000 ms default; `--timeout-ms 0` restores single-shot). `ENVELOPE_VERSION` is now `2.1` (adds the `APP_UNRESPONSIVE` code and process state in error details). FFI ABI major is `3` (append-only struct evolution; `wait --event` is intentionally not exposed over FFI). The legacy string clipboard API is removed in favor of typed content. `key-down`/`key-up` fail closed until daemon-owned held input exists. `close-app` verifies termination and the osascript fallback path is removed. `--text` matching is subtree containment: `find --text X --first` returns the outermost matching container.
47 lines
1.1 KiB
Python
47 lines
1.1 KiB
Python
import os
|
|
import subprocess
|
|
import sys
|
|
import tempfile
|
|
import unittest
|
|
|
|
import interaction_lock
|
|
|
|
|
|
PROBE = """
|
|
import fcntl, os, sys
|
|
fd = os.open(sys.argv[1], os.O_RDWR)
|
|
try:
|
|
fcntl.flock(fd, fcntl.LOCK_EX | fcntl.LOCK_NB)
|
|
except BlockingIOError:
|
|
raise SystemExit(23)
|
|
raise SystemExit(0)
|
|
"""
|
|
|
|
|
|
class InteractionLockTests(unittest.TestCase):
|
|
def probe(self, path):
|
|
return subprocess.run(
|
|
[sys.executable, "-c", PROBE, path],
|
|
check=False,
|
|
).returncode
|
|
|
|
def test_outsider_contention_and_inherited_child_crash(self):
|
|
with tempfile.TemporaryDirectory() as root:
|
|
fd = interaction_lock.acquire(root)
|
|
self.assertIsNotNone(fd)
|
|
_, path = interaction_lock.canonical_lock_path(root)
|
|
self.assertEqual(self.probe(path), 23)
|
|
|
|
subprocess.run(
|
|
[sys.executable, "-c", "import os; os._exit(71)"],
|
|
pass_fds=(fd,),
|
|
check=False,
|
|
)
|
|
self.assertEqual(self.probe(path), 23)
|
|
|
|
os.close(fd)
|
|
self.assertEqual(self.probe(path), 0)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|