mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-08-03 12:46:03 +00:00
3f322728b4
Settle the Playwright-grade reliability contract in agent-desktop-core before the Windows/Linux adapters are built, so they inherit it instead of redesigning it. Every command now observes, waits, verifies, and reports honestly instead of firing blindly. Highlights: capability-supertrait split of PlatformAdapter with not_supported() defaults; canonical role/state vocabulary with live `is --property visible`; display enumeration (`list-displays`) and honest `--screen` with scale factor; truthful Automation permission; `native_id` identity spine; window-id-first resolution; serializable `LocatorQuery` with live `find`; default-on auto-wait before every ref action; three-way `hit_test` occlusion gate; `scroll_into_view` in core; core accessible-name precedence; typed `ActionStep` delivery tier; `ProcessState` and `APP_UNRESPONSIVE`; `LaunchOptions`; baseline-diff desktop signals (`wait --event`); typed clipboard (`Text`/`Image`/`FileUrls`); mouse modifier chords and `mouse-wheel`. Hardened through a 35-reviewer pass with independent validation and a green live e2e gate (109/0), plus a head-vs-main performance comparison harness. BREAKING CHANGE: default-on auto-wait changes the timing of every previously-untouched ref-action call (bounded 5000 ms default; `--timeout-ms 0` restores single-shot). `ENVELOPE_VERSION` is now `2.1` (adds the `APP_UNRESPONSIVE` code and process state in error details). FFI ABI major is `3` (append-only struct evolution; `wait --event` is intentionally not exposed over FFI). The legacy string clipboard API is removed in favor of typed content. `key-down`/`key-up` fail closed until daemon-owned held input exists. `close-app` verifies termination and the osascript fallback path is removed. `--text` matching is subtree containment: `find --text X --first` returns the outermost matching container.
72 lines
2.4 KiB
Python
72 lines
2.4 KiB
Python
from electron_metrics_common import MeasurementError, parse_envelope
|
|
from json_tool import run_bounded
|
|
|
|
|
|
def target_window_id(windows):
|
|
visible = [
|
|
window
|
|
for window in windows
|
|
if window.get("visible") is True and window.get("minimized") is not True
|
|
]
|
|
if len(visible) == 1:
|
|
return visible[0]["id"]
|
|
focused = [window for window in visible if window.get("is_focused") is True]
|
|
if len(focused) == 1:
|
|
return focused[0]["id"]
|
|
raise MeasurementError("state probe requires one unambiguous visible target window")
|
|
|
|
|
|
def capture_app_state(runner, args):
|
|
def invoke(*arguments):
|
|
result = run_bounded(
|
|
[runner.binary, *arguments],
|
|
timeout_seconds=args.timeout_seconds,
|
|
max_capture_bytes=args.capture_limit_bytes,
|
|
env=runner.environment,
|
|
inherit_interaction_lease=True,
|
|
)
|
|
return parse_envelope(result, f"state probe {' '.join(arguments)}")["data"]
|
|
|
|
apps = invoke("list-apps", "--app", args.app).get("apps", [])
|
|
exact = [item for item in apps if item.get("name", "").casefold() == args.app.casefold()]
|
|
if len(exact) != 1 or not exact[0].get("process_instance"):
|
|
raise MeasurementError("state probe requires one exact app with a process generation")
|
|
process = exact[0]
|
|
windows = [
|
|
window
|
|
for window in invoke("list-windows", "--app", args.app)
|
|
if window.get("pid") == process.get("pid")
|
|
]
|
|
if not windows or any(
|
|
not window.get("id")
|
|
or window.get("process_instance") != process.get("process_instance")
|
|
for window in windows
|
|
):
|
|
raise MeasurementError("state probe requires exact-generation windows")
|
|
state_fields = (
|
|
"id",
|
|
"title",
|
|
"pid",
|
|
"process_instance",
|
|
"bounds",
|
|
"is_focused",
|
|
"minimized",
|
|
"visible",
|
|
)
|
|
normalized_windows = sorted(
|
|
({key: window.get(key) for key in state_fields} for window in windows),
|
|
key=lambda window: window["id"],
|
|
)
|
|
return {
|
|
"app": {
|
|
key: process.get(key)
|
|
for key in ("name", "pid", "bundle_id", "process_instance")
|
|
},
|
|
"target_window_id": target_window_id(normalized_windows),
|
|
"windows": normalized_windows,
|
|
}
|
|
|
|
|
|
def assert_stable(reference, observed, phase):
|
|
if observed != reference:
|
|
raise MeasurementError(f"app process generation or window state changed {phase}")
|