mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-07-28 18:03:00 +00:00
3f322728b4
Settle the Playwright-grade reliability contract in agent-desktop-core before the Windows/Linux adapters are built, so they inherit it instead of redesigning it. Every command now observes, waits, verifies, and reports honestly instead of firing blindly. Highlights: capability-supertrait split of PlatformAdapter with not_supported() defaults; canonical role/state vocabulary with live `is --property visible`; display enumeration (`list-displays`) and honest `--screen` with scale factor; truthful Automation permission; `native_id` identity spine; window-id-first resolution; serializable `LocatorQuery` with live `find`; default-on auto-wait before every ref action; three-way `hit_test` occlusion gate; `scroll_into_view` in core; core accessible-name precedence; typed `ActionStep` delivery tier; `ProcessState` and `APP_UNRESPONSIVE`; `LaunchOptions`; baseline-diff desktop signals (`wait --event`); typed clipboard (`Text`/`Image`/`FileUrls`); mouse modifier chords and `mouse-wheel`. Hardened through a 35-reviewer pass with independent validation and a green live e2e gate (109/0), plus a head-vs-main performance comparison harness. BREAKING CHANGE: default-on auto-wait changes the timing of every previously-untouched ref-action call (bounded 5000 ms default; `--timeout-ms 0` restores single-shot). `ENVELOPE_VERSION` is now `2.1` (adds the `APP_UNRESPONSIVE` code and process state in error details). FFI ABI major is `3` (append-only struct evolution; `wait --event` is intentionally not exposed over FFI). The legacy string clipboard API is removed in favor of typed content. `key-down`/`key-up` fail closed until daemon-owned held input exists. `close-app` verifies termination and the osascript fallback path is removed. `--text` matching is subtree containment: `find --text X --first` returns the outermost matching container.
89 lines
2.7 KiB
Python
89 lines
2.7 KiB
Python
#!/usr/bin/env python3
|
|
import fcntl
|
|
import os
|
|
import stat
|
|
import subprocess
|
|
import sys
|
|
|
|
|
|
LEASE_FD_ENV = "AGENT_DESKTOP_INTERACTION_LEASE_FD"
|
|
|
|
|
|
def canonical_lock_path(root="/tmp"):
|
|
directory = os.path.join(root, f"agent-desktop-{os.geteuid()}")
|
|
return directory, os.path.join(directory, "interaction.lock")
|
|
|
|
|
|
def _prepare_directory(directory):
|
|
try:
|
|
os.mkdir(directory, 0o700)
|
|
except FileExistsError:
|
|
pass
|
|
metadata = os.lstat(directory)
|
|
if not stat.S_ISDIR(metadata.st_mode) or stat.S_ISLNK(metadata.st_mode):
|
|
raise RuntimeError("interaction lease parent is not a real directory")
|
|
if metadata.st_uid != os.geteuid():
|
|
raise RuntimeError("interaction lease parent is not owned by this user")
|
|
os.chmod(directory, 0o700)
|
|
|
|
|
|
def acquire(root="/tmp"):
|
|
directory, path = canonical_lock_path(root)
|
|
_prepare_directory(directory)
|
|
flags = os.O_RDWR | os.O_CREAT
|
|
if hasattr(os, "O_NOFOLLOW"):
|
|
flags |= os.O_NOFOLLOW
|
|
fd = os.open(path, flags, 0o600)
|
|
metadata = os.fstat(fd)
|
|
if not stat.S_ISREG(metadata.st_mode) or metadata.st_uid != os.geteuid():
|
|
os.close(fd)
|
|
raise RuntimeError("interaction lease is not a private user-owned regular file")
|
|
if metadata.st_nlink != 1:
|
|
os.close(fd)
|
|
raise RuntimeError("interaction lease has an unexpected link count")
|
|
os.fchmod(fd, 0o600)
|
|
try:
|
|
fcntl.flock(fd, fcntl.LOCK_EX | fcntl.LOCK_NB)
|
|
except BlockingIOError:
|
|
os.close(fd)
|
|
return None
|
|
os.set_inheritable(fd, True)
|
|
return fd
|
|
|
|
|
|
def verify_inherited(raw_fd):
|
|
fd = int(raw_fd)
|
|
if fd < 0:
|
|
raise ValueError("interaction lease FD must be nonnegative")
|
|
metadata = os.fstat(fd)
|
|
_, path = canonical_lock_path()
|
|
canonical = os.stat(path, follow_symlinks=False)
|
|
if (metadata.st_dev, metadata.st_ino) != (canonical.st_dev, canonical.st_ino):
|
|
raise RuntimeError("interaction lease FD does not identify the canonical lock")
|
|
return fd
|
|
|
|
|
|
def run(command):
|
|
fd = acquire()
|
|
if fd is None:
|
|
print("SKIP (blocked): canonical desktop interaction lease is held", file=sys.stderr)
|
|
return 2
|
|
try:
|
|
environment = os.environ.copy()
|
|
environment[LEASE_FD_ENV] = str(fd)
|
|
return subprocess.run(command, env=environment, pass_fds=(fd,), check=False).returncode
|
|
finally:
|
|
os.close(fd)
|
|
|
|
|
|
def main():
|
|
if len(sys.argv) >= 3 and sys.argv[1] == "run":
|
|
raise SystemExit(run(sys.argv[2:]))
|
|
if len(sys.argv) == 3 and sys.argv[1] == "verify":
|
|
verify_inherited(sys.argv[2])
|
|
return
|
|
raise SystemExit("usage: interaction_lock.py run COMMAND... | verify FD")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|