mirror of
https://github.com/lahfir/agent-desktop.git
synced 2026-07-26 17:12:15 +00:00
3f322728b4
Settle the Playwright-grade reliability contract in agent-desktop-core before the Windows/Linux adapters are built, so they inherit it instead of redesigning it. Every command now observes, waits, verifies, and reports honestly instead of firing blindly. Highlights: capability-supertrait split of PlatformAdapter with not_supported() defaults; canonical role/state vocabulary with live `is --property visible`; display enumeration (`list-displays`) and honest `--screen` with scale factor; truthful Automation permission; `native_id` identity spine; window-id-first resolution; serializable `LocatorQuery` with live `find`; default-on auto-wait before every ref action; three-way `hit_test` occlusion gate; `scroll_into_view` in core; core accessible-name precedence; typed `ActionStep` delivery tier; `ProcessState` and `APP_UNRESPONSIVE`; `LaunchOptions`; baseline-diff desktop signals (`wait --event`); typed clipboard (`Text`/`Image`/`FileUrls`); mouse modifier chords and `mouse-wheel`. Hardened through a 35-reviewer pass with independent validation and a green live e2e gate (109/0), plus a head-vs-main performance comparison harness. BREAKING CHANGE: default-on auto-wait changes the timing of every previously-untouched ref-action call (bounded 5000 ms default; `--timeout-ms 0` restores single-shot). `ENVELOPE_VERSION` is now `2.1` (adds the `APP_UNRESPONSIVE` code and process state in error details). FFI ABI major is `3` (append-only struct evolution; `wait --event` is intentionally not exposed over FFI). The legacy string clipboard API is removed in favor of typed content. `key-down`/`key-up` fail closed until daemon-owned held input exists. `close-app` verifies termination and the osascript fallback path is removed. `--text` matching is subtree containment: `find --text X --first` returns the outermost matching container.
51 lines
1.4 KiB
Python
51 lines
1.4 KiB
Python
import importlib.util
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
|
|
MODULE_PATH = Path(__file__).with_name("check_rust_comments.py")
|
|
SPEC = importlib.util.spec_from_file_location("check_rust_comments", MODULE_PATH)
|
|
COMMENTS = importlib.util.module_from_spec(SPEC)
|
|
SPEC.loader.exec_module(COMMENTS)
|
|
|
|
|
|
class RustCommentScannerTests(unittest.TestCase):
|
|
def test_ignores_doc_comments_and_comment_markers_in_strings(self):
|
|
source = '''
|
|
/// Public documentation.
|
|
//! Module documentation.
|
|
let url = "https://example.test/path";
|
|
let marker = "/* not a comment */";
|
|
let raw = r###"// still text /* still text */"###;
|
|
'''
|
|
|
|
self.assertEqual(COMMENTS.forbidden_comments(source), [])
|
|
|
|
def test_reports_line_and_block_comments_only_in_rust_code(self):
|
|
source = '''
|
|
// standalone
|
|
let value = 1; // trailing
|
|
/* block */
|
|
let other = 2; /* trailing block */
|
|
'''
|
|
|
|
findings = COMMENTS.forbidden_comments(source)
|
|
|
|
self.assertEqual(
|
|
findings,
|
|
[
|
|
(2, "non-doc line comment"),
|
|
(3, "end-of-line comment"),
|
|
(4, "block comment"),
|
|
(5, "block comment"),
|
|
],
|
|
)
|
|
|
|
def test_nested_doc_blocks_do_not_expose_inner_markers(self):
|
|
source = "/** docs with /* nested */ text */\nlet value = 1;\n"
|
|
|
|
self.assertEqual(COMMENTS.forbidden_comments(source), [])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|