docs: require performance baseline check in definition of done

Document the head-vs-main comparison harness in the common commands and
close the agent guide with a gate: substantive changes end with
scripts/perf-baseline-compare.sh and a review of report.html against the
merge-base, so latency deltas are intentional rather than discovered by
users.
This commit is contained in:
Lahfir 2026-07-19 12:29:58 -07:00
parent ee88ee8323
commit 77ea6d1e36

View file

@ -16,6 +16,7 @@ cargo fmt --all -- --check # Format check
cargo fmt --all # Auto-format
cargo tree -p agent-desktop-core # Verify no platform crate leaks (CI enforces)
bash tests/e2e/run.sh # E2E: real binary vs fixture app, verify by observation (needs --release + AX permission)
bash scripts/perf-baseline-compare.sh # Perf A/B vs merge-base -> report.html (add --apps "Slack,Google Chrome" for Electron coverage)
```
Run the binary: `./target/release/agent-desktop snapshot --app Finder -i`
@ -397,3 +398,7 @@ same surface. Adding a command: see the Extensibility Pattern above.
- PRD v2.0: `docs/agent_desktop_prd_v2.pdf`
- Architecture Brainstorm: `docs/brainstorms/2026-02-19-architecture-validation-brainstorm.md`
- Phase 1 Plan: `docs/plans/2026-02-19-feat-agent-desktop-phase1-foundation-plan.md`
## Definition of Done: Performance Baseline
Every substantive change ends with a performance baseline check before merge: run `bash scripts/perf-baseline-compare.sh` (optionally `--apps "Slack,Google Chrome"` for dense Electron/Chromium coverage) and review the generated `report.html` against the merge-base. Latency deltas must be intentional and explainable — never discovered by users.