From 63a85422038a4d6f1f1f7906683fc00aa5d34b71 Mon Sep 17 00:00:00 2001
From: cranci1 <100066266+cranci1@users.noreply.github.com>
Date: Tue, 14 Jul 2026 17:02:58 +0200
Subject: [PATCH] Alright, i ain't refactoring Settings scheme

---
 Sora/Utlis & Misc/Modules/ModuleManager.swift | 28 +++++++
 .../Utlis & Misc/Modules/ModuleSettings.swift | 75 ++++++++++++++-----
 2 files changed, 86 insertions(+), 17 deletions(-)

diff --git a/Sora/Utlis & Misc/Modules/ModuleManager.swift b/Sora/Utlis & Misc/Modules/ModuleManager.swift
index 156cb15..7d6a6cd 100644
--- a/Sora/Utlis & Misc/Modules/ModuleManager.swift	
+++ b/Sora/Utlis & Misc/Modules/ModuleManager.swift	
@@ -243,6 +243,8 @@ class ModuleManager: ObservableObject {
                     )
                     
                     updatedModules.append((index, updatedModule))
+                    try jsContent.write(to: localUrl, atomically: true, encoding: .utf8)
+                    try? writeSettingsToFile(for: updatedModule)
                     Logger.shared.log("Prepared update for module: \(module.metadata.sourceName) to version \(newMetadata.version)")
                 }
             } catch {
@@ -260,4 +262,30 @@ class ModuleManager: ObservableObject {
             Logger.shared.log("Successfully updated \(updatedModules.count) modules")
         }
     }
+    
+    func writeSettingsToFile(for module: ScrapingModule) throws {
+        let url = getDocumentsDirectory().appendingPathComponent(module.localPath)
+        var content = try String(contentsOf: url, encoding: .utf8)
+        let overrides = loadSettingOverrides(for: module)
+        guard !overrides.isEmpty else { return }
+        
+        for (key, value) in overrides {
+            let pattern = #"^(\s*)const\s+\#(key)\s*=\s*.*?;(.*)$"#
+            let regex = try NSRegularExpression(pattern: pattern, options: .anchorsMatchLines)
+            let range = NSRange(location: 0, length: content.utf16.count)
+            let newLine = "$1const \(key) = \(formatForJS(value));$2"
+            content = regex.stringByReplacingMatches(in: content, options: [], range: range, withTemplate: newLine)
+        }
+
+        try content.write(to: url, atomically: true, encoding: .utf8)
+    }
+
+    private func formatForJS(_ value: String) -> String {
+        if let _ = Int(value) { return value }
+        if let _ = Double(value) { return value }
+        if value.lowercased() == "true" || value.lowercased() == "false" { return value.lowercased() }
+        
+        let escaped = value.replacingOccurrences(of: "\\", with: "\\\\").replacingOccurrences(of: "\"", with: "\\\"")
+        return "\"\(escaped)\""
+    }
 }
diff --git a/Sora/Utlis & Misc/Modules/ModuleSettings.swift b/Sora/Utlis & Misc/Modules/ModuleSettings.swift
index f384d30..a9316f3 100644
--- a/Sora/Utlis & Misc/Modules/ModuleSettings.swift	
+++ b/Sora/Utlis & Misc/Modules/ModuleSettings.swift	
@@ -84,14 +84,19 @@ extension ModuleManager {
         for setting in settings {
             overrides[setting.key] = setting.value
         }
-        
         guard let data = try? JSONEncoder().encode(overrides) else {
-            Logger.shared.log("Failed to encode settings for module: \(module.metadata.sourceName)", type: "Error")
+            Logger.shared.log("Failed to encode settings", type: "Error")
             return false
         }
-        
         UserDefaults.standard.set(data, forKey: settingsStorageKey(for: module))
-        Logger.shared.log("Updated settings for module: \(module.metadata.sourceName)")
+        
+        do {
+            try writeSettingsToFile(for: module)
+            Logger.shared.log("File updated with new settings")
+        } catch {
+            Logger.shared.log("Failed to write settings to file: \(error)", type: "Error")
+            return false
+        }
         return true
     }
     
@@ -99,7 +104,7 @@ extension ModuleManager {
         "moduleSettings_\(module.id.uuidString)"
     }
     
-    private func loadSettingOverrides(for module: ScrapingModule) -> [String: String] {
+    func loadSettingOverrides(for module: ScrapingModule) -> [String: String] {
         guard
             let data = UserDefaults.standard.data(forKey: settingsStorageKey(for: module)),
             let dict = try? JSONDecoder().decode([String: String].self, from: data)
@@ -108,19 +113,55 @@ extension ModuleManager {
     }
     
     fileprivate static func parseSettingsSchema(from script: String) -> [ModuleSettingSchemaEntry] {
-        guard
-            let markerRange = script.range(of: "SETTINGS_SCHEMA:"),
-            let lineEnd = script[markerRange.upperBound...].firstIndex(of: "\n")
-        else { return [] }
-        
-        let jsonString = String(script[markerRange.upperBound..<lineEnd]).trimmingCharacters(in: .whitespaces)
-        guard let data = jsonString.data(using: .utf8) else { return [] }
-        
-        do {
-            return try JSONDecoder().decode([ModuleSettingSchemaEntry].self, from: data)
-        } catch {
-            Logger.shared.log("Failed to parse SETTINGS_SCHEMA: \(error.localizedDescription)", type: "Error")
+        guard let start = script.range(of: "// Settings start"),
+              let end = script.range(of: "// Settings end", range: start.upperBound..<script.endIndex) else {
             return []
         }
+
+        let block = String(script[start.upperBound..<end.lowerBound])
+        let lines = block.split(separator: "\n", omittingEmptySubsequences: false)
+        var entries: [ModuleSettingSchemaEntry] = []
+
+        let pattern = #"^const\s+(\w+)\s*=\s*(.+?);(?:\s*//\s*(.*))?$"#
+        guard let regex = try? NSRegularExpression(pattern: pattern) else { return [] }
+
+        for line in lines {
+            let trimmed = line.trimmingCharacters(in: .whitespaces)
+            guard !trimmed.isEmpty && !trimmed.hasPrefix("//") else { continue }
+
+            let nsLine = trimmed as NSString
+            guard let match = regex.firstMatch(in: trimmed, range: NSRange(location: 0, length: nsLine.length)) else { continue }
+
+            let key = nsLine.substring(with: match.range(at: 1))
+            let rawValue = nsLine.substring(with: match.range(at: 2)).trimmingCharacters(in: .whitespaces)
+            let comment = match.range(at: 3).location != NSNotFound ? nsLine.substring(with: match.range(at: 3)).trimmingCharacters(in: .whitespaces) : nil
+
+            var defaultValue = rawValue
+            if (rawValue.hasPrefix("\"") && rawValue.hasSuffix("\"")) ||
+               (rawValue.hasPrefix("'") && rawValue.hasSuffix("'")) {
+                defaultValue = String(rawValue.dropFirst().dropLast())
+            }
+
+            let type: String
+            if let _ = Int(defaultValue) {
+                type = "int"
+            } else if let _ = Double(defaultValue), defaultValue.contains(".") {
+                type = "float"
+            } else if defaultValue.lowercased() == "true" || defaultValue.lowercased() == "false" {
+                type = "bool"
+            } else {
+                type = "string"
+            }
+
+            let entry = ModuleSettingSchemaEntry(
+                key: key,
+                type: type,
+                comment: comment,
+                defaultValue: defaultValue,
+                options: nil
+            )
+            entries.append(entry)
+        }
+        return entries
     }
 }